Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement]: Controller dosenot depend on TableService #3425

Merged
merged 9 commits into from
Feb 6, 2025
Merged

[Improvement]: Controller dosenot depend on TableService #3425

merged 9 commits into from
Feb 6, 2025

Conversation

baiyangtx
Copy link
Contributor

@baiyangtx baiyangtx commented Jan 23, 2025 •
edited
Loading

Why are the changes needed?

As a subtask of #3346, this PR will make RestController do not depend on TableService which is a statefull service

Brief change log

  • Caculate TableOptimizingInfo from database meta.
  • Cancel process through a thrift api call to OptimizingService

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

zhoujinsong
zhoujinsong approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the contribution!

...rc/main/java/org/apache/amoro/server/persistence/extension/InListExtendedLanguageDriver.java
* </script>
* </pre>
*/
public class InListExtendedLanguageDriver extends XMLLanguageDriver implements LanguageDriver {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some code(OptimizingMapper, TableMetaMapper) still used old style, we may improve them in another PR.

@zhoujinsong zhoujinsong merged commit 677e344 into apache:master Feb 6, 2025
4 checks passed
@baiyangtx baiyangtx deleted the no-table-service-in-controller branch February 6, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhoujinsong zhoujinsong zhoujinsong approved these changes

Assignees
No one assigned
Labels
module:ams-server Ams server module module:common type:build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baiyangtx @zhoujinsong